Update pysmartdatamodels.py #57
Open
+51
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ngsi_ld_example_generator_str() function to be able to generate fake examples before the model is published.
|
We appreciate the contribution but we would need also the changes in the README file showing an example of execution of the new function. Thus we could test the contribution. |
Added the ngsi_ld_example_generator_str() function to be able to generate fake examples before the model is published.
|
Updated, hope that it is sufficient. |
Added the ngsi_ld_example_generator_str() function to be able to generate fake examples before the model is published.
|
Thank you I am reviewing the code and what happens if the schema is not correct. this error is not controlled and therefore the function just throw an error without much information |
|
Added a similar error handling as implemented elsewhere in the package. |
|
We are solving other issues about the package. please be patient with this approval |
|
I need you to hold a call to understand better the contribution before merging. please book it here https://calendly.com/smartdatamodels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ngsi_ld_example_generator_str() function to be able to generate fake examples before the model is published.